No description
  • Perl 81.1%
  • Batchfile 16.3%
  • C 1.9%
  • Makefile 0.7%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Michael Köppl 1db755c9bb fix #8030: snapshot: avoid orphaned vmstate volume on failure
The state volume was allocated before the running instance was queried
for its machine type, CPU argument and network MTUs. Those queries can
fail (e.g. the 'query-machines' QMP command, which can run into a
timeout while QEMU's is busy [0]).

The helper is called from __snapshot_prepare() before write_config(), so
the config never records the snapshot, snapshot_create() dies before it
gets to its cleanup path. Such a failure leaves behind the just
allocated volume.

Query the running instance first, which makes the allocation the last
step of the function that can fail.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=8030

Signed-off-by: Michael Köppl <[email protected]>
Reviewed-by: Elias Huhsovitz <[email protected]>
Tested-by: Elias Huhsovitz <[email protected]>
Reviewed-by: Jakob Klocker <[email protected]>
Tested-by: Jakob Klocker <[email protected]>
Link: https://lore.proxmox.com/[email protected]
2026-09-22 15:20:43 +02:00
debian bump version to 9.2.9 2026-09-10 21:55:46 +02:00
src fix #8030: snapshot: avoid orphaned vmstate volume on failure 2026-09-22 15:20:43 +02:00
.gitignore gitignore: sort content 2023-11-17 15:54:24 +01:00
Makefile make: use host-architecture and pass to upload target 2026-03-30 14:27:07 +02:00